CHI-3259: language select poc #2955
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lts going blank. Fix orphaned case check
mythilytm
reviewed
May 7, 2025
| { "label": "English", "aseloLocale": "en-US" }, | ||
| { "label": "Thai", "aseloLocale": "th-TH" }, | ||
| { "label": "Español", "aseloLocale": "es-CL" } | ||
| ] |
There was a problem hiding this comment.
Instead of hrm-form-definitions/form-definitions/as/v1/flexUiLocales.json, I think it will be good to have this in the hrm-form-definitions/form-definitions/as/v1/customStrings/ folder.
There was a problem hiding this comment.
I considered that, but they aren't custom strings really, just another config setting
| <Translator manager={Flex.Manager.getInstance()} translateUI={translateUI} key="locale-selector" />, | ||
| { align: 'end', sortOrder: 0 }, | ||
| ); | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rough POC for language select. Configured via a new json in the form definitions fold
One major missing feature is a notification telling the user to reload the page. Also proper UX is required to go to production
Can be merged because having an empty config switches it off
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P